[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87shz58wbw.fsf@intel.com>
Date: Fri, 01 Apr 2016 13:20:03 +0300
From: Felipe Balbi <felipe.balbi@...ux.intel.com>
To: Grygorii Strashko <grygorii.strashko@...com>,
"Thang Q. Nguyen" <tqnguyen@....com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-usb@...r.kernel.org, linux-omap@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm@...ts.infradead.org,
Arnd Bergmann <arnd@...db.de>,
"Karicheri\, Muralidharan" <m-karicheri2@...com>,
Peter Ujfalusi <peter.ujfalusi@...com>, Phong Vo <pvo@....com>,
Loc Ho <lho@....com>, patches <patches@....com>,
Santosh Shilimkar <ssantosh@...nel.org>,
"Ben Dooks \(embedded platforms\)" <ben-linux@...ff.org>
Subject: Re: [PATCH v3 2/2] usb:dwc3: pass arch data to xhci-hcd child
Hi,
Grygorii Strashko <grygorii.strashko@...com> writes:
>> if of_dma_configure() does what you want, why don't you just stick it in
>> dwc3-keystone.c and let the driver continue to copy things for now ?
>> Something like below, perhaps ?
>>
>
> I know (and i have patch to fix that which I'm going to send) that DMA config
> in dwc3-keystone.c is not correct and we are good till now just
> because dwc3_keystone is not used for DMA operations directly.
>
> Now about xhci and friends:
> dwc3_keystone *is created* from DT : of_platform_device_create() -> of_platform_device_create_pdata() -> of_dma_configure()
> |- dwc3 *is created* from DT : of_platform_device_create() -> of_platform_device_create_pdata() -> of_dma_configure()
> |- [1] *creates* xhci dev manually : DMA configuration copied manually in dwc3_host_init()
> |- [2] *creates* usb_gadget dev manually: DMA configuration copied manually in usb_add_gadget_udc_release()
> |- *creates* usb_udc dev manually : not used for DMA operations directly (as I've checked)
>
> Now cases [1] & [2] introduces failures, because DMA configuration is not complete for
> these devices.
right, then we just copy whatever's missing, right ? Until there's a
generic way of copying these bits, I want to avoid introducing any of_*
specific methodologies and prefer to have the manual copy.
> I can confirm that if I fix [1] & [2] as above USB Device/Dual modes will start
> working on K2E.
cool, I'd be happy to take both patches ;-)
--
balbi
Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)
Powered by blists - more mailing lists