linux-kernel - Re: [PATCH v2] gpio: pca953x: Use correct u16 value for register word write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADO9-pfvRUnKM104YbM2PEewWSh3K0qqS-LJoUqXbN-UEdbdNg@mail.gmail.com>
Date:	Fri, 1 Apr 2016 22:38:55 +0800
From:	Yong Li <sdliyong@...il.com>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Alexandre Courbot <gnurou@...il.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Alexander Stein <alexander.stein@...tec-electronic.com>,
	Phil Reid <preid@...ctromag.com.au>
Subject: Re: [PATCH v2] gpio: pca953x: Use correct u16 value for register word write

Yes it is a regression. I think it should be tagged for stable too

Thanks,
Yong

2016-04-01 20:51 GMT+08:00 Linus Walleij <linus.walleij@...aro.org>:
> On Wed, Mar 30, 2016 at 8:49 AM, Yong Li <sdliyong@...il.com> wrote:
>
>> The current implementation only uses the first byte in val,
>> the second byte is always 0. Change it to use cpu_to_le16
>> to write the two bytes into the register
>>
>> Signed-off-by: Yong Li <sdliyong@...il.com>
>
> Patch applied to fixes with Phil's review tag.
>
> It is a regression, right?
>
> Should it be tagged for stable?
>
> Yours,
> Linus Walleij