linux-kernel - [PATCH] selftests: media_device_test fix to close the fd before exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1459827686-11155-1-git-send-email-shuahkh@osg.samsung.com>
Date:	Mon,  4 Apr 2016 21:41:26 -0600
From:	Shuah Khan <shuahkh@....samsung.com>
To:	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:	Shuah Khan <shuahkh@....samsung.com>
Subject: [PATCH] selftests: media_device_test fix to close the fd before exit

Fix it to close the fd before exit and in error legs.

Signed-off-by: Shuah Khan <shuahkh@....samsung.com>
---
 tools/testing/selftests/media_tests/media_device_test.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/tools/testing/selftests/media_tests/media_device_test.c b/tools/testing/selftests/media_tests/media_device_test.c
index cbf53a0..dfb3ca6 100644
--- a/tools/testing/selftests/media_tests/media_device_test.c
+++ b/tools/testing/selftests/media_tests/media_device_test.c
@@ -84,12 +84,14 @@ int main(int argc, char **argv)
 
 	while (count < 100) {
 		ret = ioctl(fd, MEDIA_IOC_DEVICE_INFO, &mdi);
-		if (ret < 0)
+		if (ret < 0) {
 			printf("Media Device Info errno %s\n", strerror(errno));
-		else
-			printf("Media device model %s driver %s\n",
-				mdi.model, mdi.driver);
+			break;
+		}
+		printf("Media device model %s driver %s\n",
+			mdi.model, mdi.driver);
 		sleep(10);
 		count++;
 	}
+	close(fd);
 }
-- 
2.5.0