linux-kernel - Re: [PATCH v3] Fix OpenSSH pty regression on close

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5703344E.6060300@hurleysoftware.com>
Date:	Mon, 4 Apr 2016 20:43:10 -0700
From:	Peter Hurley <peter@...leysoftware.com>
To:	Brian Bloniarz <brian.bloniarz@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Jiri Slaby <jslaby@...e.com>, linux-kernel@...r.kernel.org,
	tsi@...oix.net
Subject: Re: [PATCH v3] Fix OpenSSH pty regression on close

On 03/06/2016 01:16 PM, Brian Bloniarz wrote:
> OpenSSH expects the (non-blocking) read() of pty master to return
> EAGAIN only if it has received all of the slave-side output after
> it has received SIGCHLD. This used to work on pre-3.12 kernels.
> 
> This fix effectively forces non-blocking read() and poll() to
> block for parallel i/o to complete for all ttys. It also unwinds
> these changes:
> 
> 1) f8747d4a466ab2cafe56112c51b3379f9fdb7a12
>    tty: Fix pty master read() after slave closes
> 
> 2) 52bce7f8d4fc633c9a9d0646eef58ba6ae9a3b73
>    pty, n_tty: Simplify input processing on final close
> 
> 3) 1a48632ffed61352a7810ce089dc5a8bcd505a60
>    pty: Fix input race when closing

Reviewed-by: Peter Hurley <peter@...leysoftware.com>