linux-kernel - Re: [PATCH] tpm: remove redundant code from self-test functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160405094221.GA12672@intel.com>
Date:	Tue, 5 Apr 2016 12:42:21 +0300
From:	Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
Cc:	Peter Huewe <peterhuewe@....de>,
	Marcel Selhorst <tpmdd@...horst.net>,
	"moderated list:TPM DEVICE DRIVER" 
	<tpmdd-devel@...ts.sourceforge.net>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tpm: remove redundant code from self-test functions

On Fri, Apr 01, 2016 at 09:16:15PM -0600, Jason Gunthorpe wrote:
> On Thu, Mar 31, 2016 at 09:37:56AM +0300, Jarkko Sakkinen wrote:
> > On Wed, Mar 30, 2016 at 11:46:23PM -0600, Jason Gunthorpe wrote:
> > > On Wed, Mar 30, 2016 at 04:20:45PM +0300, Jarkko Sakkinen wrote:
> > >   
> > > > -		rc = be32_to_cpu(cmd.header.out.return_code);
> > > >  		if (rc == TPM_ERR_DISABLED || rc == TPM_ERR_DEACTIVATED) {
> > > 
> > > This line is the entire reason it is open coded, I see it being
> > > removed, but I don't see how the functionality is maintained?
> > 
> > When tpm_trance_cmd() returns a positive number it is the TPM error code
> > that it returns. tpm_pcr_read() does pass through whatever
> > tpm_trace_cmd() returns so the above condition should still work as
> > expected.
> 
> Okay, everything looks fine to me

I applied this to http://git.infradead.org/users/jjs/linux-tpmdd.git in
order to get exposure (tested-by's are always welcome).

> Jason

/Jarkko