linux-kernel - Re: [PATCH 2/7] crypto: sha256-mb - SHA256 multibuffer job manager and glue code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160405120357.GA12510@gondor.apana.org.au>
Date:	Tue, 5 Apr 2016 20:03:57 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	megha.dey@...ux.intel.com
Cc:	davem@...emloft.net, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org, tim.c.chen@...ux.intel.com,
	fenghua.yu@...el.com, Megha Dey <megha.dey@...el.com>
Subject: Re: [PATCH 2/7] crypto: sha256-mb - SHA256 multibuffer job manager
 and glue code

On Thu, Mar 24, 2016 at 01:25:58PM -0700, megha.dey@...ux.intel.com wrote:
> From: Megha Dey <megha.dey@...el.com>
> 
> This patch introduces the multi-buffer job manager which is responsible for
> submitting scatter-gather buffers from several SHA256 jobs to the
> multi-buffer algorithm. It also contains the flush routine to that's
> called by the crypto daemon to complete the job when no new jobs arrive
> before the deadline of maximum latency of a SHA256 crypto job.
> 
> The SHA256 multi-buffer crypto algorithm is defined and initialized in
> this patch.
> 
> Signed-off-by: Megha Dey <megha.dey@...ux.intel.com>
> Reviewed-by: Fenghua Yu <fenghua.yu@...el.com>
> Reviewed-by: Tim Chen <tim.c.chen@...ux.intel.com>

sha1-mb still has the same issues that I complained about for the
aes-mb submission.  In particular, I don't like the use of shash
to handle what is really an async implmentation.

So I'd like to see this fixed first before we add any more copies
of this code.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt