linux-kernel - RE: [PATCH 2/7] crypto: sha256-mb - SHA256 multibuffer job manager and glue code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3E5A0FA7E9CA944F9D5414FEC6C712205DFA3CFB@ORSMSX106.amr.corp.intel.com>
Date:	Fri, 8 Apr 2016 18:37:05 +0000
From:	"Yu, Fenghua" <fenghua.yu@...el.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>,
	"megha.dey@...ux.intel.com" <megha.dey@...ux.intel.com>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"tim.c.chen@...ux.intel.com" <tim.c.chen@...ux.intel.com>,
	"Dey, Megha" <megha.dey@...el.com>
Subject: RE: [PATCH 2/7] crypto: sha256-mb - SHA256 multibuffer job manager
 and glue code

> From: Herbert Xu [mailto:herbert@...dor.apana.org.au]
> Sent: Tuesday, April 05, 2016 5:04 AM
> To: megha.dey@...ux.intel.com
> Cc: davem@...emloft.net; linux-crypto@...r.kernel.org; linux-
> kernel@...r.kernel.org; tim.c.chen@...ux.intel.com; Yu, Fenghua
> <fenghua.yu@...el.com>; Dey, Megha <megha.dey@...el.com>
> Subject: Re: [PATCH 2/7] crypto: sha256-mb - SHA256 multibuffer job
> manager and glue code
> 
> On Thu, Mar 24, 2016 at 01:25:58PM -0700, megha.dey@...ux.intel.com
> wrote:
> > From: Megha Dey <megha.dey@...el.com>
> >
> > This patch introduces the multi-buffer job manager which is
> > responsible for submitting scatter-gather buffers from several SHA256
> > jobs to the multi-buffer algorithm. It also contains the flush routine
> > to that's called by the crypto daemon to complete the job when no new
> > jobs arrive before the deadline of maximum latency of a SHA256 crypto job.
> >
> > The SHA256 multi-buffer crypto algorithm is defined and initialized in
> > this patch.
> >
> > Signed-off-by: Megha Dey <megha.dey@...ux.intel.com>
> > Reviewed-by: Fenghua Yu <fenghua.yu@...el.com>
> > Reviewed-by: Tim Chen <tim.c.chen@...ux.intel.com>
> 
> sha1-mb still has the same issues that I complained about for the aes-mb
> submission.  In particular, I don't like the use of shash to handle what is really
> an async implmentation.
> 
> So I'd like to see this fixed first before we add any more copies of this code.

We will update the patches and re-send out sha1/256/512 AVX2 mb algos using async implementation.

Thanks.

-Fenghua