linux-kernel - Re: [PATCH v6 01/12] usb: hcd: Initialize hcd->flags to 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zit72rqz.fsf@intel.com>
Date:	Wed, 06 Apr 2016 09:09:08 +0300
From:	Felipe Balbi <balbi@...nel.org>
To:	Roger Quadros <rogerq@...com>, stern@...land.harvard.edu,
	gregkh@...uxfoundation.org, peter.chen@...escale.com
Cc:	dan.j.williams@...el.com, jun.li@...escale.com,
	mathias.nyman@...ux.intel.com, tony@...mide.com,
	Joao.Pinto@...opsys.com, abrestic@...omium.org,
	r.baldyga@...sung.com, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
	Roger Quadros <rogerq@...com>
Subject: Re: [PATCH v6 01/12] usb: hcd: Initialize hcd->flags to 0


Hi,

Roger Quadros <rogerq@...com> writes:
> diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
> index 2ca2cef..6b1930d 100644
> --- a/drivers/usb/core/hcd.c
> +++ b/drivers/usb/core/hcd.c
> @@ -2706,6 +2706,7 @@ int usb_add_hcd(struct usb_hcd *hcd,
>  	int retval;
>  	struct usb_device *rhdev;
>  
> +	hcd->flags = 0;

seems like this would make more sense in usb_del_hcd() instead.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)