linux-kernel - Re: [PATCH 1/3] intel_pstate: Use pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160406150112.GC16889@vireshk-i7>
Date:	Wed, 6 Apr 2016 20:31:12 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Doug Smythies <dsmythies@...us.net>
Cc:	'Srinivas Pandruvada' <srinivas.pandruvada@...ux.intel.com>,
	'Joe Perches' <joe@...ches.com>, 'Len Brown' <lenb@...nel.org>,
	"'Rafael J. Wysocki'" <rjw@...ysocki.net>,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] intel_pstate: Use pr_fmt

On 06-04-16, 07:51, Doug Smythies wrote:
> On 2016.04.05 02:44 Srinivas Pandruvada wrote:
> > On Tue, 2016-04-05 at 13:28 -0700, Joe Perches wrote:
> >> Prefix the output using the more common kernel style.
> >> 
> >> Signed-off-by: Joe Perches <joe@...ches.com>
> > Acked-by: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
> >> ---
> >>  drivers/cpufreq/intel_pstate.c | 18 ++++++++++--------
> >>  1 file changed, 10 insertions(+), 8 deletions(-)
> 
> ...[cut, example left]...
> 
> > -		pr_warn("intel_pstate: Turbo disabled by BIOS or
> > unavailable on processor\n");
> > +		pr_warn("Turbo disabled by BIOS or unavailable on
> > processor\n");
> 
> I do  not understand.
> The common and unique string "intel_pstate" was added on purpose
> so as to provide a way to easily extract the related message from
> an otherwise huge log file.

The first line of the patch does this:

+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

which will automagically add name of the current file (intel_pstate)
before every print message printed using pr_*() helpers.

-- 
viresh