linux-kernel - Re: [PATCH 01/20] mfd: Add devm_ apis for mfd_add_devices and mfd_release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 Apr 2016 12:42:50 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	corbet@....net, andreas.werner@....de, tony@...mide.com,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-omap@...r.kernel.org, patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH 01/20] mfd: Add devm_ apis for mfd_add_devices and
 mfd_release_devices

On Thu, 07 Apr 2016, Laxman Dewangan wrote:

> Hi Lee,
> Thanks for review.
> I will send another patch with incorporating your comments.
> 
> 
> On Thursday 07 April 2016 04:14 PM, Lee Jones wrote:
> >On Tue, 05 Apr 2016, Laxman Dewangan wrote:
> >
> >+	if (!ret) {
> >+		*ptr = dev;
> >+		devres_add(dev, ptr);
> >+	} else {
> >+		devres_free(ptr);
> >+	}
> >Switch these round.  If you encounter a problem, free and return.  If
> >not, skip the error handling and add the device outside of the if().
> 
> Like below?
> 
> if (ret) {
>      devres_free(ptr);
>      return ret;
> }
> 
> *ptr = dev;
> devres_add(dev, ptr);
> 
> return ret;

This is more in line with what I expect, yes.

> >>+ * Remove all mfd devices added on the device.
> >s/mfd/MFD/
> >
> >'D' already means devices, so here you are saying "devices devices".
> >Please re-word.  Besides, you need to be more specific as to which
> >"devices on the devices" you are detailing, since this sentence
> >doesn't really make a great deal of sense.
> Wanted to say
> Remove all devices added by mfd_add_devices()  from parent device.

Remove all chlid-devices?

> >>+ * Normally this function will not need to be called and the resource
> >>+ * management code will ensure that the resource is freed.
> >Then what is the purpose of providing it?  Do you have a user?
> 
> To have pair of release. I have not seen the usage of most of
> devm_*_release() function other than devm_kfree().

Unless you have a need or a user, I would omit this for now.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog