[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160407175600.GN16484@atomide.com>
Date: Thu, 7 Apr 2016 10:56:01 -0700
From: Tony Lindgren <tony@...mide.com>
To: Grygorii Strashko <grygorii.strashko@...com>
Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>, linux-pm@...r.kernel.org,
Pavel Machek <pavel@....cz>, nsekhar@...com, nm@...com,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
Len Brown <len.brown@...el.com>, linux-omap@...r.kernel.org
Subject: Re: [RFC PATCH] PM / wakeirq: fix wakeirq setting after wakup
re-configuration from sysfs
* Grygorii Strashko <grygorii.strashko@...com> [160406 04:47]:
> Now wakeirq stops working for device if wakeup option for
> this device will be reconfigured through sysfs, like:
>
> echo disabled > /sys/devices/platform/extcon_usb1/power/wakeup
> echo enabled > /sys/devices/platform/extcon_usb1/power/wakeup
>
> Once above set of commands is executed the device's wakeup_source
> opject will be recreated and dev->power.wakeup->wakeirq field will
> contain NULL. As result, device_wakeup_arm_wake_irqs() will not arm
> wakeirq for the affected device.
>
> Hece, lets try to fix it in the following way:
> check for dev->wakeirq field when device_wakeup_attach() is called
> and if !NULL re-attach wakeirq to the device
Yeah I think that's all there is to it, thanks for fixing it:
Acked-by: Tony Lindgren <tony@...mide.com>
Powered by blists - more mailing lists