linux-kernel - Re: [RFC PATCH] PM / wakeirq: fix wakeirq setting after wakup re-configuration from sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1664339.h6rI5IB9Xd@vostro.rjw.lan>
Date:	Thu, 07 Apr 2016 23:25:50 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Tony Lindgren <tony@...mide.com>,
	Grygorii Strashko <grygorii.strashko@...com>
Cc:	linux-pm@...r.kernel.org, Pavel Machek <pavel@....cz>,
	nsekhar@...com, nm@...com, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, Len Brown <len.brown@...el.com>,
	linux-omap@...r.kernel.org
Subject: Re: [RFC PATCH] PM / wakeirq: fix wakeirq setting after wakup re-configuration from sysfs

On Thursday, April 07, 2016 10:56:01 AM Tony Lindgren wrote:
> * Grygorii Strashko <grygorii.strashko@...com> [160406 04:47]:
> > Now wakeirq stops working for device if wakeup option for
> > this device will be reconfigured through sysfs, like:
> > 
> > echo disabled > /sys/devices/platform/extcon_usb1/power/wakeup
> > echo enabled > /sys/devices/platform/extcon_usb1/power/wakeup
> > 
> > Once above set of commands is executed the device's wakeup_source
> > opject will be recreated and dev->power.wakeup->wakeirq field will
> > contain NULL. As result, device_wakeup_arm_wake_irqs() will not arm
> > wakeirq for the affected device.
> > 
> > Hece, lets try to fix it in the following way:
> >   check for dev->wakeirq field when device_wakeup_attach() is called
> >   and if !NULL re-attach wakeirq to the device
> 
> Yeah I think that's all there is to it, thanks for fixing it:
> 
> Acked-by: Tony Lindgren <tony@...mide.com>

Applied, thanks!