linux-kernel - Re: [PATCH 2/4] drivers/bus: make imx-weim.c explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160407025819.GC3111@x250>
Date:	Thu, 7 Apr 2016 10:58:20 +0800
From:	Shawn Guo <shawnguo@...nel.org>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
	Wolfram Sang <wsa@...-dreams.de>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Will Deacon <will.deacon@....com>,
	Olof Johansson <olof@...om.net>,
	Shawn Guo <shawn.guo@...aro.org>,
	Alison Chaiken <alison_chaiken@...tor.com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/4] drivers/bus: make imx-weim.c explicitly non-modular

On Sun, Mar 27, 2016 at 05:10:56PM -0400, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
> 
> drivers/bus/Kconfig:config IMX_WEIM
> drivers/bus/Kconfig:    bool "Freescale EIM DRIVER
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> Since module_platform_driver() uses the same init level priority as
> builtin_platform_driver() the init ordering remains unchanged with
> this commit.
> 
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
> 
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
> 
> Cc: Shawn Guo <shawn.guo@...aro.org>

Acked-by: Shawn Guo <shawn.guo@...aro.org>

> Cc: Alison Chaiken <alison_chaiken@...tor.com>
> Cc: Sascha Hauer <s.hauer@...gutronix.de>
> Cc: Wolfram Sang <wsa@...-dreams.de>
> Cc: linux-arm-kernel@...ts.infradead.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>