linux-kernel - Re: [PATCH 1/4] drivers/bus: make brcmstb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <570D42F5.6070308@gmail.com>
Date:	Tue, 12 Apr 2016 11:48:21 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Brian Norris <computersforpeace@...il.com>,
	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	linux-kernel@...r.kernel.org, Olof Johansson <olof@...om.net>,
	Will Deacon <will.deacon@....com>,
	Arnd Bergmann <arnd@...db.de>,
	Gregory Fong <gregory.0xf0@...il.com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/4] drivers/bus: make brcmstb_gisb.c driver explicitly
 non-modular

On 06/04/16 18:26, Brian Norris wrote:
> On Sun, Mar 27, 2016 at 05:10:55PM -0400, Paul Gortmaker wrote:
>> The Kconfig for this driver is currently:
>>
>> config BRCMSTB_GISB_ARB
>>         bool "Broadcom STB GISB bus arbiter"
>>
>> ...meaning that it currently is not being built as a module by anyone.
>> Lets remove all modular references, so that when reading the driver
>> there is no doubt it is builtin-only.
>>
>> Since module_init translates to device_initcall in the non-modular
>> case, the init ordering remains unchanged with this commit.
>>
>> Cc: Brian Norris <computersforpeace@...il.com>
>> Cc: Gregory Fong <gregory.0xf0@...il.com>
>> Cc: Florian Fainelli <f.fainelli@...il.com>
>> Cc: linux-arm-kernel@...ts.infradead.org
>> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> 
> I think this driver probably doesn't make too much sense as a module
> anyway (among other things, we can't hook the ARM fault handler beyond
> init time, as it's marked __init). So:
> 
> Acked-by: Brian Norris <computersforpeace@...il.com>
> 
> Might be good to get Florian's ack though, as I'm not using this
> platform any more.

I concur with Brian here, your changes look good:

Acked-by: Florian Fainelli <f.fainelli@...il.com>

Thanks Paul
-- 
Florian