linux-kernel - Re: [alsa-devel] [PATCH 2/5 v4] drm/i2c/adv7511: Add audio support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <570B6DF2.1080008@synopsys.com>
Date:	Mon, 11 Apr 2016 10:27:14 +0100
From:	Jose Abreu <Jose.Abreu@...opsys.com>
To:	Lars-Peter Clausen <lars@...afoo.de>,
	Jose Abreu <Jose.Abreu@...opsys.com>,
	<linux-snps-arc@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
	<alsa-devel@...a-project.org>
CC:	<architt@...eaurora.org>, <airlied@...ux.ie>,
	<Vineet.Gupta1@...opsys.com>, <Alexey.Brodkin@...opsys.com>,
	<lgirdwood@...il.com>, <CARLOS.PALMINHA@...opsys.com>,
	<broonie@...nel.org>, <tiwai@...e.com>
Subject: Re: [alsa-devel] [PATCH 2/5 v4] drm/i2c/adv7511: Add audio support

Hi Lars,


On 09-04-2016 16:02, Lars-Peter Clausen wrote:
> On 04/08/2016 06:12 PM, Jose Abreu wrote:
> [...]
>>> [...]
>>>> +- adi,enable-audio: If set the ADV7511 driver will register a codec interface
>>>> +  into ALSA SoC.
>>> This is not a description of the hardware.
>> Is this okay: "adi,enable-audio: Set this boolean parameter if ADV7511
>> transmitter routes audio signals" ?
> I don't think we need this property. There is no problem with registering
> the audio part unconditionally. As long as there is no connection we wont
> create a sound card that is exposed to userspace.
>

This change was suggested by Laurent Pinchart and was introduced in v3. Quoting
Laurent:
"The idea is that enabling support for ADV7511 audio in the kernel isn't coupled
with whether the system includes audio support. It would be confusing, and would
also waste resources, to create a Linux sound device when no sound channel is
routed on the board."

Should I revert this?

Best regards,
Jose Miguel Abreu