linux-kernel - Re: [PATCH v2 07/11] serial: 8250: enable AFE on ports where FIFO is 16 bytes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <570BBA53.4080508@hurleysoftware.com>
Date:	Mon, 11 Apr 2016 07:53:07 -0700
From:	Peter Hurley <peter@...leysoftware.com>
To:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:	Bryan O'Donoghue <pure.logic@...us-software.ie>,
	linux-serial@...r.kernel.org, Vinod Koul <vinod.koul@...el.com>,
	linux-kernel@...r.kernel.org, dmaengine@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	ismo.puustinen@...el.com,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Subject: Re: [PATCH v2 07/11] serial: 8250: enable AFE on ports where FIFO is
 16 bytes

On 04/11/2016 05:51 AM, Andy Shevchenko wrote:
> Intel Quark has 16550A compatible UART with autoflow feature enabled. It has
> only 16 bytes of FIFO. Currently serial8250_do_set_termios() prevents to enable
> autoflow since the minimum requirement of 32 bytes of FIFO size.
> 
> Drop a FIFO size limitation to allow autoflow control be enabled on such UARTs.
> 
> While here, comment out UART_CAP_AFE for PORT_AR7 since it wasn't working and
> it will be not a good idea to use it in conjunction with trigger level of 1
> byte.

Reviewed-by: Peter Hurley <peter@...leysoftware.com>