linux-kernel - [4.5-rc4 Regression] qla2xxx: Add irq affinity notification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <570BDE44.5020301@canonical.com>
Date:	Mon, 11 Apr 2016 13:26:28 -0400
From:	Joseph Salisbury <joseph.salisbury@...onical.com>
To:	quinn.tran@...gic.com
Cc:	qla2xxx-upstream@...gic.com, jejb@...ux.vnet.ibm.com,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	linux-scsi@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	hch@....de, bart.vanassche@...disk.com,
	himanshu.madhani@...gic.com, nab@...ux-iscsi.org
Subject: [4.5-rc4 Regression] qla2xxx: Add irq affinity notification

Hello Quinn,

A kernel bug report was opened against Ubuntu [0].  After a kernel
bisect, it was found that reverting the following commit resolved this bug:

commit cdb898c52d1dfad4b4800b83a58b3fe5d352edde
Author: Quinn Tran <quinn.tran@...gic.com>
Date: Thu Dec 17 14:57:05 2015 -0500

    qla2xxx: Add irq affinity notification

However, the prior commit also required the following three commits to
also be reverted:

commit 5327c7dbd1a7fd980608f44789076a636e5ee5fc
Author: Quinn Tran <quinn.tran@...gic.com>
Date: Wed Feb 10 18:59:14 2016 -0500

    qla2xxx: use TARGET_SCF_USE_CPUID flag to indiate CPU Affinity

commit 9095adaab8c1d82707e4e9961b6ad79b62f3361b
Author: Quinn Tran <quinn.tran@...gic.com>
Date: Wed Feb 10 18:59:13 2016 -0500

    target/transport: add flag to indicate CPU Affinity is observed

commit fb3269baf4ecc2ce6d17d4eb537080035bdf6d5b
Author: Quinn Tran <quinn.tran@...gic.com>
Date: Thu Dec 17 14:57:06 2015 -0500

    qla2xxx: Add selective command queuing

The regression was introduced as of v4.5-rc4.

I was hoping to get your feedback, since you are the patch author. The
dependant reverts all look like they are improving cpu affinity, which
would likely impact performance.  Do you thing there is a way forward
instead of the reverts, or would it be best to submit a revert request?

Thanks,

Joe

[0] http://pad.lv/1554003