lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 12 Apr 2016 06:52:37 +0000 From: "Du, Changbin" <changbin.du@...el.com> To: Felipe Balbi <balbi@...nel.org> CC: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>, "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: RE: [PATCH] usb: dwc3: free dwc->regset on dwc3_debugfs_exit Hi, Balbi, > > Hmm, I agree from this point. I will combine this patch with other two > patches > > (due to their dependency). And I'd like remove the 'dwc->root=NULL' as > well, > > you are creating a dependency that doesn't exist. Please stop that. You > should have two separate branches based on v4.6-rc3 (or, if you prefer, > one based on my testing/fixes and another based on my testing/next). On > one branch you have *only* $subject and you fix *all* the memory > leaks. On the other branch you have the other two patches. > > Ignore the fact that we might have a conflict, that's for git (and > maintainers) to handle when they happen. > > Again, don't create dependencies between fixes for the -rc cycle and > changes for the next merge window. > Thanks for dedicated explanation. I was concern about the conflict. Now it is very clear for me to handle such situation. > > Is it ok for you? > > yeah, please remove root = NULL as that's completely unnecessary, but > split these patches in separate branches and fix all memory leaks. > > -- > balbi
Powered by blists - more mailing lists