linux-kernel - RE: [PATCH] usb: dwc3: free dwc->regset on dwc3_debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87mvozl08d.fsf@intel.com>
Date:	Tue, 12 Apr 2016 11:06:42 +0300
From:	Felipe Balbi <balbi@...nel.org>
To:	"Du\, Changbin" <changbin.du@...el.com>
Cc:	"gregkh\@linuxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-usb\@vger.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] usb: dwc3: free dwc->regset on dwc3_debugfs_exit


Hi,

"Du, Changbin" <changbin.du@...el.com> writes:
> Hi, Balbi,
>
>> > Hmm, I agree from this point. I will combine this patch with other two
>> patches
>> > (due to their dependency). And I'd like remove the 'dwc->root=NULL' as
>> well,
>> 
>> you are creating a dependency that doesn't exist. Please stop that. You
>> should have two separate branches based on v4.6-rc3 (or, if you prefer,
>> one based on my testing/fixes and another based on my testing/next). On
>> one branch you have *only* $subject and you fix *all* the memory
>> leaks. On the other branch you have the other two patches.
>> 
>> Ignore the fact that we might have a conflict, that's for git (and
>> maintainers) to handle when they happen.
>> 
>> Again, don't create dependencies between fixes for the -rc cycle and
>> changes for the next merge window.
>> 
> Thanks for dedicated explanation. I was concern about the conflict.

yeah, no problem ;-)

> Now it is very clear for me to handle such situation.

good :-) glad we could sort it out.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)