[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160412105609.GF18882@ulmo.ba.sec>
Date: Tue, 12 Apr 2016 12:56:09 +0200
From: Thierry Reding <thierry.reding@...il.com>
To: Lee Jones <lee.jones@...aro.org>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
kernel@...inux.com, maxime.coquelin@...com,
linux-pwm@...r.kernel.org, ajitpal.singh@...com
Subject: Re: [RESEND 10/11] pwm: sti: Enable PWM Capture
On Wed, Mar 02, 2016 at 03:32:08PM +0000, Lee Jones wrote:
> Once all functionality is in place, we provide the means to
> enable PWM Capture. Here we are simply obtaining the
> associated regmap and twiddling the relevant enable register
> bits.
>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
> drivers/pwm/pwm-sti.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/pwm/pwm-sti.c b/drivers/pwm/pwm-sti.c
> index 8de9b4a..93cf20e 100644
> --- a/drivers/pwm/pwm-sti.c
> +++ b/drivers/pwm/pwm-sti.c
> @@ -279,6 +279,13 @@ static int sti_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm)
> pwm->hwpwm);
> goto out;
> }
> +
> + ret = regmap_field_write(pc->pwm_cpt_en, 1);
> + if (ret) {
> + dev_err(dev, "failed to enable PWM capture:%d\n",
> + pwm->hwpwm);
> + goto out;
> + }
Should this perhaps be part of the driver's ->capture() implementation?
It seems redundant to have this logic enabled if we may never use it.
Thierry
Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)
Powered by blists - more mailing lists