[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-id: <570CD4F7.6000700@samsung.com>
Date: Tue, 12 Apr 2016 12:59:03 +0200
From: Krzysztof Kozlowski <k.kozlowski@...sung.com>
To: Chanwoo Choi <cw00.choi@...sung.com>, myungjoo.ham@...sung.com,
kyungmin.park@...sung.com, kgene@...nel.org,
s.nawrocki@...sung.com, tomasz.figa@...il.com
Cc: rjw@...ysocki.net, robh+dt@...nel.org, pawel.moll@....com,
mark.rutland@....com, ijc+devicetree@...lion.org.uk,
galak@...eaurora.org, linux@....linux.org.uk,
linux.amoon@...il.com, m.reichl@...etechno.de,
tjakobi@...h.uni-bielefeld.de, inki.dae@...sung.com,
linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
linux-samsung-soc@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 7/7] ARM: dts: Add support of Bus frequency using VDD_INT
for exynos5422-odroidxu3
On 04/08/2016 07:00 AM, Chanwoo Choi wrote:
> This patch adds the bus device tree nodes for INT (Internal) block
> to enable the AMBA bus frequency scaling and add the NoC (Network on Chip)
> Probe Device Tree node to measure the bandwidht for AMBA AXI bus.
>
> The WCORE bus bus is parent device in INT block using VDD_INT.
>
> Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>
> ---
> arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 99 ++++++++++++++++++++++
> 1 file changed, 99 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> index 1bd507bfa750..2a74abe6fc5d 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> @@ -361,6 +361,22 @@
> cap-sd-highspeed;
> };
>
> +&nocp_mem0_0 {
> + status = "okay";
> +};
> +
> +&nocp_mem0_1 {
> + status = "okay";
> +};
> +
> +&nocp_mem0_2 {
> + status = "okay";
> +};
> +
> +&nocp_mem0_3 {
> + status = "okay";
> +};
> +
> &pinctrl_0 {
> hdmi_hpd_irq: hdmi-hpd-irq {
> samsung,pins = "gpx3-7";
> @@ -432,3 +448,86 @@
> vdd33-supply = <&ldo9_reg>;
> vdd10-supply = <&ldo11_reg>;
> };
> +
> +&bus_wcore {
> + devfreq-events = <&nocp_mem0_0>, <&nocp_mem0_1>,
> + <&nocp_mem0_2>, <&nocp_mem0_3>;
> + vdd-supply = <&buck3_reg>;
> + exynos,saturation-ratio = <100>;
> + status = "okay";
> +};
> +
> +&bus_noc {
> + devfreq = <&bus_wcore>;
> + status = "okay";
> +};
> +
> +&bus_fsys_apb {
> + devfreq = <&bus_wcore>;
> + status = "okay";
> +};
> +
> +&bus_fsys {
> + devfreq = <&bus_wcore>;
> + status = "okay";
> +};
> +
> +&bus_fsys2 {
> + devfreq = <&bus_wcore>;
> + status = "okay";
> +};
> +
> +&bus_mfc {
> + devfreq = <&bus_wcore>;
> + status = "okay";
> +};
> +
> +&bus_gen {
> + devfreq = <&bus_wcore>;
> + status = "okay";
> +};
> +
> +&bus_peri {
> + devfreq = <&bus_wcore>;
> + status = "okay";
> +};
> +
> +&bus_g2d {
> + devfreq = <&bus_wcore>;
> + status = "okay";
> +};
> +
> +&bus_g2d_acp {
> + devfreq = <&bus_wcore>;
> + status = "okay";
> +};
> +
> +&bus_jpeg {
> + devfreq = <&bus_wcore>;
> + status = "okay";
> +};
> +
> +&bus_jpeg_apb {
> + devfreq = <&bus_wcore>;
> + status = "okay";
> +};
> +
> +&bus_disp1_fimd {
> + devfreq = <&bus_wcore>;
> + status = "okay";
> +};
> +
> +&bus_disp1 {
> + devfreq = <&bus_wcore>;
> + status = "okay";
> +};
> +
> +&bus_gscl_scaler {
> + devfreq = <&bus_wcore>;
> + status = "okay";
> +};
> +
> +&bus_mscl {
> + devfreq = <&bus_wcore>;
> + status = "okay";
> +};
Could you put the bus nodes in alphabetical order, both between them and
in relation to others (so before &clock_audss)? Let's keep the file ordered.
Best regards,
Krzysztof
Powered by blists - more mailing lists