linux-kernel - Re: [PATCH] watchdog: dw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <570CF2CB.2050200@roeck-us.net>
Date:	Tue, 12 Apr 2016 06:06:19 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Wim Van Sebroeck <wim@...ana.be>,
	Haavard Skinnemoen <hskinnemoen@...il.com>,
	Hans-Christian Egtvedt <egtvedt@...fundet.no>
Cc:	linux-kernel@...r.kernel.org, kernel-testers@...r.kernel.org,
	linux-watchdog@...r.kernel.org
Subject: Re: [PATCH] watchdog: dw_wdt: dont build for avr32

On 04/11/2016 10:51 PM, Sudip Mukherjee wrote:
> The build of avr32 allmodconfig fails with the error:
> ERROR: "__avr32_udiv64" [drivers/watchdog/kempld_wdt.ko] undefined!
>
This means there is a direct 64 bit divide operation in the driver,
which we should identify and fix.

Guenter

> Exclude this driver from the build of avr32.
>
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>
> ---
>
> avr32 build log is at:
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/122158665
>
>   drivers/watchdog/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index fb94765..61041ba 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -981,7 +981,7 @@ config HP_WATCHDOG
>
>   config KEMPLD_WDT
>   	tristate "Kontron COM Watchdog Timer"
> -	depends on MFD_KEMPLD
> +	depends on MFD_KEMPLD && !AVR32
>   	select WATCHDOG_CORE
>   	help
>   	  Support for the PLD watchdog on some Kontron ETX and COMexpress
>