lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 12 Apr 2016 15:06:27 +0200 From: Boris Brezillon <boris.brezillon@...e-electrons.com> To: Thierry Reding <thierry.reding@...il.com> Cc: linux-pwm@...r.kernel.org, Mike Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...eaurora.org>, linux-clk@...r.kernel.org, Mark Brown <broonie@...nel.org>, Liam Girdwood <lgirdwood@...il.com>, Kamil Debski <k.debski@...sung.com>, lm-sensors@...sensors.org, Jean Delvare <jdelvare@...e.com>, Guenter Roeck <linux@...ck-us.net>, Dmitry Torokhov <dmitry.torokhov@...il.com>, linux-input@...r.kernel.org, Bryan Wu <cooloney@...il.com>, Richard Purdie <rpurdie@...ys.net>, Jacek Anaszewski <j.anaszewski@...sung.com>, linux-leds@...r.kernel.org, Maxime Ripard <maxime.ripard@...e-electrons.com>, Chen-Yu Tsai <wens@...e.org>, linux-sunxi@...glegroups.com, Joachim Eastwood <manabian@...il.com>, Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>, Heiko Stuebner <heiko@...ech.de>, linux-rockchip@...ts.infradead.org, Jingoo Han <jingoohan1@...il.com>, Lee Jones <lee.jones@...aro.org>, linux-fbdev@...r.kernel.org, Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>, Tomi Valkeinen <tomi.valkeinen@...com>, Robert Jarzmik <robert.jarzmik@...e.fr>, Alexandre Belloni <alexandre.belloni@...e-electrons.com>, Kukjin Kim <kgene@...nel.org>, Krzysztof Kozlowski <k.kozlowski@...sung.com>, linux-samsung-soc@...r.kernel.org, intel-gfx@...ts.freedesktop.org, Daniel Vetter <daniel.vetter@...el.com>, Jani Nikula <jani.nikula@...ux.intel.com>, Jonathan Corbet <corbet@....net>, linux-doc@...r.kernel.org, David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>, dri-devel@...ts.freedesktop.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, Hartley Sweeten <hsweeten@...ionengravers.com>, Ryan Mallon <rmallon@...il.com>, Alexander Shiyan <shc_work@...l.ru>, Milo Kim <milo.kim@...com> Subject: Re: [PATCH v5 05/46] pwm: introduce the pwm_args concept On Tue, 12 Apr 2016 13:39:12 +0200 Thierry Reding <thierry.reding@...il.com> wrote: > On Wed, Mar 30, 2016 at 10:03:28PM +0200, Boris Brezillon wrote: > > Currently the PWM core mixes the current PWM state with the per-platform > > reference config (specified through the PWM lookup table, DT definition or > > directly hardcoded in PWM drivers). > > > > Create a pwm_args struct to store this reference config, so that PWM users > > can differentiate the current config from the reference one. > > > > Patch all places where pwm->args should be initialized. We keep the > > pwm_set_polarity/period() calls until all PWM users are patched to > > use pwm_args instead of pwm_get_period/polarity(). > > Perhaps a helper would be useful? Something like: > > static inline void > pwm_apply_args(struct pwm_device *pwm, const struct pwm_args *args) > { > pwm_set_duty_cycle(pwm, args->duty_cycle); > pwm_set_period(pwm, args->period); > } > > ? That would make it slightly easier to get rid of it again after all > clients have been converted. > > With the exception of pwm-clps711x all of these args are set at of_xlate > time (for DT) or from the lookup table in pwm_get() (for non-DT), so it > might even be possible to move this call to the core, so that removal of > it will be a one-liner. Okay, I think I misunderstood your suggestion. I thought you wanted this helper to set the reference config, but you actually want to apply a new state based on the PWM reference values. Except that pwm_args does not contain all the required information to apply a full config (args->duty_cycle and args->enable do not exist). This being said, in my v6 I moved the content of pwm_regulator_adjust_pwm_config() (patch 27) into a generic helper (pwm_adjust_config()). This helper is doing pretty much what you're suggesting here (but again, I'm not sure I correctly understood your suggestion :-/). -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Powered by blists - more mailing lists