linux-kernel - Re: [PATCH net v3] net: sched: do not requeue a NULL skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1460478227.6473.590.camel@edumazet-glaptop3.roam.corp.google.com>
Date:	Tue, 12 Apr 2016 09:23:47 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Lars Persson <lars.persson@...s.com>
Cc:	netdev@...r.kernel.org, jhs@...atatu.com,
	linux-kernel@...r.kernel.org, xiyou.wangcong@...il.com,
	Lars Persson <larper@...s.com>
Subject: Re: [PATCH net v3] net: sched: do not requeue a NULL skb

On Tue, 2016-04-12 at 08:45 +0200, Lars Persson wrote:
> A failure in validate_xmit_skb_list() triggered an unconditional call
> to dev_requeue_skb with skb=NULL. This slowly grows the queue
> discipline's qlen count until all traffic through the queue stops.

> 
> Fixes: 55a93b3ea780 ("qdisc: validate skb without holding lock")
> Signed-off-by: Lars Persson <larper@...s.com>
> ---


Acked-by: Eric Dumazet <edumazet@...gle.com>

Thanks !