linux-kernel - Re: [PATCH V2 1/3] acpi,pci,irq: reduce resource requirements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <570D2170.303@codeaurora.org>
Date:	Tue, 12 Apr 2016 12:25:20 -0400
From:	Sinan Kaya <okaya@...eaurora.org>
To:	Bjorn Helgaas <helgaas@...nel.org>
Cc:	linux-acpi@...r.kernel.org, timur@...eaurora.org,
	cov@...eaurora.org, linux-pci@...r.kernel.org,
	ravikanth.nalla@....com, lenb@...nel.org, harish.k@....com,
	ashwin.reghunandanan@....com, bhelgaas@...gle.com,
	rjw@...ysocki.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 1/3] acpi,pci,irq: reduce resource requirements

On 4/12/2016 1:19 AM, Bjorn Helgaas wrote:
> Hi Sinan,
> 
> I was hoping we could *simplify* this, but I think it's just getting
> even more complicated (it's a net addition of 100 lines), which is due
> to feature creep that I'm afraid is my fault.
> 
> IIRC, the main thing you need is to get rid of some early memory
> allocation.
> 
> I don't think all the trigger mode/level checking is worth it.  The
> current code doesn't do it, and it's not fixing a problem for you.
> It's conceivable that it could even make us trip over a new problem,
> e.g., some broken BIOS that we currently tolerate.
> 
> I think you could make this a little easier to review if you split
> things like the acpi_irq_penalty[] -> acpi_isa_irq_penalty[] rename
> into their own patches.  Little patches like that are trivial to
> review because a simple rename is pretty safe, and then the patches
> that actually *do* interesting things are smaller and easier to
> review, too.

OK. I honestly didn't like adding this check either. I'll work on a new
set and post with your additional comments in this patch.

-- 
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project