linux-kernel - Re: [PATCH 4.5 113/238] mtip32xx: Implement timeout handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1460429373.25201.103.camel@decadent.org.uk>
Date:	Tue, 12 Apr 2016 03:49:33 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Selvan Mani <smani@...ron.com>,
	Rajesh Kumar Sambandam <rsambandam@...ron.com>,
	Asai Thambi S P <asamymuthupa@...ron.com>
Cc:	stable@...r.kernel.org, Jens Axboe <axboe@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4.5 113/238] mtip32xx: Implement timeout handler

On Sun, 2016-04-10 at 11:34 -0700, Greg Kroah-Hartman wrote:
> 4.5-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Asai Thambi SP <asamymuthupa@...ron.com>
> 
> commit abb0ccd185c9e31847709b86192e6c815d1f57ad upstream.
> 
> Added timeout handler. Replaced blk_mq_end_request() with
> blk_mq_complete_request() to avoid double completion of a request.
> 
> Signed-off-by: Selvan Mani <smani@...ron.com>
> Signed-off-by: Rajesh Kumar Sambandam <rsambandam@...ron.com>
> Signed-off-by: Asai Thambi S P <asamymuthupa@...ron.com>
> Signed-off-by: Jens Axboe <axboe@...com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> ---
>  drivers/block/mtip32xx/mtip32xx.c |   95 ++++++++++++++++++++++++++++++++++----
>  drivers/block/mtip32xx/mtip32xx.h |    7 ++
>  2 files changed, 92 insertions(+), 10 deletions(-)
[...]

This is >100 lines (the rough limit for stable), and it's part of a
whole series of complex and inadequately explained changes.

How thoroughly have these changes been tested against 4.4 and 4.5?

Ben.

-- 
Ben Hutchings
This sentence contradicts itself - no actually it doesn't.
Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)