linux-kernel - Re: [PATCH 2/2] dts/ls1043a: add the DTS node for QSPI support

Open Source and information security mailing list archives

Message-ID: <20160412024947.GD15949@tiger>
Date:	Tue, 12 Apr 2016 10:49:47 +0800
From:	Shawn Guo <shawnguo@...nel.org>
To:	Yuan Yao <yao.yuan@...escale.com>
Cc:	robh+dt@...nel.org, mark.rutland@....com,
	computersforpeace@...il.com, pawel.moll@....com, han.xu@....com,
	leoyang.li@....com, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Yuan Yao <yao.yuan@....com>
Subject: Re: [PATCH 2/2] dts/ls1043a: add the DTS node for QSPI support

On Thu, Mar 31, 2016 at 02:45:01PM +0800, Yuan Yao wrote:
> From: Yuan Yao <yao.yuan@....com>
> 
> Signed-off-by: Yuan Yao <yao.yuan@....com>

Please style of 'arm64: dts: ls1043a: ' for subject prefix.

> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 16 ++++++++++++++++
>  arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi    | 14 ++++++++++++++
>  2 files changed, 30 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> index 97e9906..c8303a3 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> @@ -100,6 +100,22 @@
>  	};
>  };
>  
> +&qspi {

Please sort such labeled node alphabetically in label name.  That said,
it should go after &lpuart0.

> +	num-cs = <2>;

I do not see this property in bindings doc.

> +	bus-num = <0>;
> +	status = "okay";

Please let 'status' line be the last of property list.

> +	fsl,ddr-sampling-point = <4>;

I do not see this one in bindings definition either.

> +
> +	qflash0: s25fl128s@0 {
> +		compatible = "spansion,m25p80";
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		spi-max-frequency = <20000000>;
> +		ddr-quad-read;

Ditto

> +		reg = <0>;
> +	};
> +};
> +
>  &i2c0 {
>  	status = "okay";
>  	pca9547@77 {
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> index be72bf5..49b1aeb 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> @@ -208,6 +208,20 @@
>  			status = "disabled";
>  		};
>  
> +		qspi: quadspi@...0000 {

Please sort the node in <soc>.dtsi in order of unit-address.  That said,
the node should be added between ifc@...0000 and esdhc@...0000.

Shawn

> +			compatible = "fsl,ls1043a-qspi", "fsl,ls1021a-qspi";
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <0x0 0x1550000 0x0 0x10000>,
> +				<0x0 0x40000000 0x0 0x4000000>;
> +			reg-names = "QuadSPI", "QuadSPI-memory";
> +			interrupts = <0 99 0x4>;
> +			clock-names = "qspi_en", "qspi";
> +			clocks = <&clockgen 4 0>, <&clockgen 4 0>;
> +			big-endian;
> +			status = "disabled";
> +		};
> +
>  		i2c0: i2c@...0000 {
>  			compatible = "fsl,vf610-i2c";
>  			#address-cells = <1>;
> -- 
> 2.1.0.27.g96db324
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives