linux-kernel - Re: [PATCH] sched/clock: Make local_clock/cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 13 Apr 2016 11:51:07 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:	peterz@...radead.org, Ingo Molnar <mingo@...hat.com>,
	"open list:SCHEDULER" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sched/clock: Make local_clock/cpu_clock inline


* Daniel Lezcano <daniel.lezcano@...aro.org> wrote:

> On 04/13/2016 11:41 AM, Ingo Molnar wrote:
> >
> >* Daniel Lezcano <daniel.lezcano@...aro.org> wrote:
> >
> >>The local_clock/cpu_clock functions were changed to prevent a double
> >>identical test with sched_clock_cpu() when HAVE_UNSTABLE_SCHED_CLOCK
> >>is set. That resulted in one line functions.
> >>
> >>As these functions are in all the cases one line functions and in the
> >>hot path, it is useful to specify them as static inline in order to
> >>give a strong hint to the compiler.
> >>
> >>After verification, it appears the compiler does not inline them
> >>without this hint. Change those functions to static inline.
> >>
> >>Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> >>---
> >>  include/linux/sched.h | 32 ++++++++++++++++++++++++++++++--
> >>  kernel/sched/clock.c  | 41 -----------------------------------------
> >>  2 files changed, 30 insertions(+), 43 deletions(-)
> >
> >Hm, this does not seem to apply to v4.6-rc3 cleanly.
> 
> Actually I based the patches on top of tip/sched/core.

This patch does not seem to apply to tip/sched/core either (2b8c41daba32).

Thanks,

	Ingo