linux-kernel - Re: [PATCH v2] pinctrl: rockchip: add support the get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbKG5bvv=rXd+osJorvP2gUmhMWMKGfwz56r+HTYiBmOA@mail.gmail.com>
Date:	Wed, 13 Apr 2016 15:26:50 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Caesar Wang <wxt@...k-chips.com>
Cc:	Heiko Stübner <heiko@...ech.de>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>
Subject: Re: [PATCH v2] pinctrl: rockchip: add support the get_direction

On Tue, Mar 15, 2016 at 8:55 AM, Caesar Wang <wxt@...k-chips.com> wrote:

> This patch adds the get_direction to support the gpio
> interface.
>
> The gpio direction is not used on rockchip platform when use the gpio
> debugfs.
>
> Tested on kylin board. (RK3036 SoCs)
> The repro steps:
> $/sys/class/gpio/
> echo 53 > export
> $/sys/class/gpio/gpio53# cat direction
> in
> In general, the gpio53 should be out value, but the direction is the
> default value 'in',  since the get_direction didn't supported in rockchip
> pinctrl.
>
> So, we should add this patch to support it.
>
> Reported-by: Jeffy Chen <jeffy.chen@...k-chips.com>
> Signed-off-by: Caesar Wang <wxt@...k-chips.com>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Heiko Stuebner <heiko@...ech.de>
> Cc: linux-gpio@...r.kernel.org
> Cc: linux-rockchip@...ts.infradead.org
>
> ---
>
> Changes in v2:
> - As Heiko comments on (https://patchwork.kernel.org/patch/8576661/),
>   fixes the wrong offset from original patch.

Patch applied.

Yours,
Linus Walleij