linux-kernel - Re: [PATCH] device-tree: nexus7-flo: Remove power gpio key entry and use pmic8xxx-pwrkey

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <570E80CA.3080100@arm.com>
Date:	Wed, 13 Apr 2016 18:24:26 +0100
From:	Sudeep Holla <sudeep.holla@....com>
To:	John Stultz <john.stultz@...aro.org>,
	lkml <linux-kernel@...r.kernel.org>
Cc:	Sudeep Holla <sudeep.holla@....com>,
	Rob Herring <robh+dt@...nel.org>,
	Arnd Bergmann <arnd.bergmann@...aro.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Andy Gross <agross@...eaurora.org>,
	Vinay Simha BN <simhavcs@...il.com>,
	Bjorn Andersson <bjorn.andersson@...aro.org>,
	Stephen Boyd <stephen.boyd@...aro.org>,
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH] device-tree: nexus7-flo: Remove power gpio key entry and
 use pmic8xxx-pwrkey



On 13/04/16 18:16, John Stultz wrote:
> Since the pmic8xxx-pwrkey driver is already supported in the
> qcom-apq8064.dtsi, and the pmic8xxx-pwrkey supports logic to
> configure proper device shutdown when ps_hold goes low, it is
> better to use that driver then a generic gpio button.
>
> Thus this patch remove the gpio power key entry here, so we
> don't get double input events from having two drivers enabled.
>
> The one gotcha with the pmic8xxx-pwrkey is it has a fairly
> long debounce delay, which we shorten here to make the button
> behave as expected.
>
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: Arnd Bergmann <arnd.bergmann@...aro.org>
> Cc: Pawel Moll <pawel.moll@....com>
> Cc: Mark Rutland <mark.rutland@....com>
> Cc: Ian Campbell <ijc+devicetree@...lion.org.uk>
> Cc: Kumar Gala <galak@...eaurora.org>
> Cc: Andy Gross <agross@...eaurora.org>
> Cc: Vinay Simha BN <simhavcs@...il.com>
> Cc: Bjorn Andersson <bjorn.andersson@...aro.org>
> Cc: Stephen Boyd <stephen.boyd@...aro.org>
> Cc: linux-arm-msm@...r.kernel.org
> Cc: devicetree@...r.kernel.org
> Signed-off-by: John Stultz <john.stultz@...aro.org>
> ---
>   arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts | 15 +++++++++------
>   1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts b/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts
> index c535b3f..7ac1c65 100644
> --- a/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts
> +++ b/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts
> @@ -29,12 +29,6 @@
>
>   	gpio-keys {
>   		compatible = "gpio-keys";
> -		power {
> -			label = "Power";
> -			gpios = <&tlmm_pinmux 26 GPIO_ACTIVE_LOW>;
> -			linux,code = <KEY_POWER>;
> -			gpio-key,wakeup;

You are dropping wakeup with this change. Is that intentional ?

If not, while you are at this, replace it with "wakeup-source"
which is standard binding.

If yes, then it solves the problem :). I had a patch to replace it, but
was waiting to check if any new files in linux-next before posting. For
now, this is the only legacy entry.

-- 
Regards,
Sudeep