linux-kernel - Re: [PATCH] rtc: support for rv4162c7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAJk-V1M-wRMOt0BYk+Nnrb805A8wwji0yyzT2OPfGoCWuruaw@mail.gmail.com>
Date:	Thu, 14 Apr 2016 09:24:41 +0200
From:	Tomas Krcka <tomas.krcka@...roup.cz>
To:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc:	rtc-linux@...glegroups.com,
	Alessandro Zummo <a.zummo@...ertech.it>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtc: support for rv4162c7

Hi,
  ok, good. Thanks.
Patch is not needed.

2016-04-14 9:19 GMT+02:00 Alexandre Belloni
<alexandre.belloni@...e-electrons.com>:
> Hi,
>
> On 14/04/2016 at 08:29:47 +0200, Tomas Krcka wrote :
>> Hi,
>>   that's correct, but idetification of this chip is rv4162c7 so
>> i2c_match_id() returns NULL.
>> If it's there any workaround, how the chip can be detected
>> automatically then OK, but without this patch it doesn't work for me.
>>
>
> Just use rv4162 as your compatible string. That is what the mainline dtsi
> is doing for the phycore som:
>
> $ grep -C 2 rv4162 arch/arm/boot/dts/am335x-phycore-som.dtsi
>
>         i2c_rtc: rtc@68 {
>                 compatible = "rv4162";
>                 reg = <0x68>;
>                 status = "disabled";
>
>
>> 2016-04-14 0:49 GMT+02:00 Alexandre Belloni
>> <alexandre.belloni@...e-electrons.com>:
>> > Hi,
>> >
>> > On 13/04/2016 at 22:39:39 +0200, Tomas Krcka wrote :
>> >> This patch is for support of rv4162c7 RTC chip.
>> >> The device has same parameters as rv4162, but with different identification.
>> >> Tested with PhyTec module AM335x.
>> >>
>> >
>> > Well, technically, it is an rv4162. rv4162-c7 is the only available one.
>> > So this patch is not necessary.
>> >
>> >> Signed-off-by: Tomas Krcka <tomas.krcka@...roup.cz>
>> >>
>> >> ---
>> >>  drivers/rtc/rtc-m41t80.c | 1 +
>> >>  1 file changed, 1 insertion(+)
>> >>
>> >> diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c
>> >> index d107a8e..1aa57d8 100644
>> >> --- a/drivers/rtc/rtc-m41t80.c
>> >> +++ b/drivers/rtc/rtc-m41t80.c
>> >> @@ -81,6 +81,7 @@ static const struct i2c_device_id m41t80_id[] = {
>> >>      { "m41st85", M41T80_FEATURE_HT | M41T80_FEATURE_BL | M41T80_FEATURE_SQ },
>> >>      { "m41st87", M41T80_FEATURE_HT | M41T80_FEATURE_BL | M41T80_FEATURE_SQ },
>> >>      { "rv4162", M41T80_FEATURE_SQ | M41T80_FEATURE_WD | M41T80_FEATURE_SQ_ALT },
>> >> +    { "rv4162c7", M41T80_FEATURE_SQ | M41T80_FEATURE_WD | M41T80_FEATURE_SQ_ALT },
>> >>      { }
>> >>  };
>> >>  MODULE_DEVICE_TABLE(i2c, m41t80_id);
>> >> -- 1.9.1
>> >>
>> >
>> > --
>> > Alexandre Belloni, Free Electrons
>> > Embedded Linux, Kernel and Android engineering
>> > http://free-electrons.com
>
> --
> Alexandre Belloni, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com