linux-kernel - Re: [PATCH] net-next: mediatek: add support for IRQ grouping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160413.222238.1174020501502372148.davem@davemloft.net>
Date:	Wed, 13 Apr 2016 22:22:38 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	blogic@...nwrt.org
Cc:	nbd@...nwrt.org, matthias.bgg@...il.com, netdev@...r.kernel.org,
	linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net-next: mediatek: add support for IRQ grouping

From: John Crispin <blogic@...nwrt.org>
Date: Thu,  7 Apr 2016 20:24:59 +0200

> The ethernet core has 3 IRQs. Using the IRQ grouping registers we are able
> to separate TX and RX IRQs, which allows us to service them on separate
> cores. This patch splits the IRQ handler into 2 separate functions, one
> for TX and another for RX. The TX housekeeping is split out of the NAPI
> handler. Instead we use a tasklet to handle housekeeping.
> 
> Signed-off-by: John Crispin <blogic@...nwrt.org>

Don't do this with tasklets.

Do your TX reclaim in a NAPI poll just like the RX side.