linux-kernel - Re: [PATCH V2 03/15] coresight: tmc: re-implementing tmc_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 15 Apr 2016 18:41:17 +0100
From:	Suzuki K Poulose <Suzuki.Poulose@....com>
To:	Mathieu Poirier <mathieu.poirier@...aro.org>
Cc:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2 03/15] coresight: tmc: re-implementing
 tmc_read_prepare/unprepare() functions

On 15/04/16 16:40, Mathieu Poirier wrote:
> On 14 April 2016 at 11:11, Suzuki K Poulose <Suzuki.Poulose@....com> wrote:

>>
>> Nit. If you move the TMC_CONFIG_TYPE_ETB here, you could fall through from
>> TYPE_ETF: i.e,
>
> Yes, that's what the end result look like [1].  I will refactor to
> make the transition cleaner.
>
> [1]. https://git.linaro.org/kernel/coresight.git/blob/refs/heads/next:/drivers/hwtracing/coresight/coresight-tmc.c#l76

Ok, no need to refactor here then.

>>
>> Reviewed-by: Suzuki K Poulose <suzuki.poulose@....com>

Cheers
Suzuki