linux-kernel - Re: [RFC 6/8] drm/fence: create DRM_MODE_ATOMIC_OUT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 15 Apr 2016 12:05:53 -0700
From:	Gustavo Padovan <gustavo@...ovan.org>
To:	Rob Clark <robdclark@...il.com>
Cc:	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Daniel Stone <daniels@...labora.com>,
	Arve Hjønnevåg <arve@...roid.com>,
	Riley Andrews <riandrews@...roid.com>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	Greg Hackmann <ghackmann@...gle.com>,
	John Harrison <John.C.Harrison@...el.com>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Sean Paul <seanpaul@...gle.com>,
	Stéphane Marchesin <marcheu@...gle.com>,
	Mauro Carvalho Chehab <m.chehab@...sung.com>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Gustavo Padovan <gustavo.padovan@...labora.co.uk>
Subject: Re: [RFC 6/8] drm/fence: create DRM_MODE_ATOMIC_OUT_FENCE flag


2016-04-14 Rob Clark <robdclark@...il.com>:

> On Thu, Apr 14, 2016 at 9:29 PM, Gustavo Padovan <gustavo@...ovan.org> wrote:
> > From: Gustavo Padovan <gustavo.padovan@...labora.co.uk>
> >
> > This flag tells drm_atomic_ioctl that we want to get a per-crtc out-fence
> > fd back.
> >
> > Signed-off-by: Gustavo Padovan <gustavo.padovan@...labora.co.uk>
> > ---
> >  include/uapi/drm/drm_mode.h | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h
> > index 7a7856e..39905cc 100644
> > --- a/include/uapi/drm/drm_mode.h
> > +++ b/include/uapi/drm/drm_mode.h
> > @@ -582,13 +582,15 @@ struct drm_mode_destroy_dumb {
> >  #define DRM_MODE_ATOMIC_TEST_ONLY 0x0100
> >  #define DRM_MODE_ATOMIC_NONBLOCK  0x0200
> >  #define DRM_MODE_ATOMIC_ALLOW_MODESET 0x0400
> > +#define DRM_MODE_ATOMIC_OUT_FENCE 0x0800
> >
> >  #define DRM_MODE_ATOMIC_FLAGS (\
> >                 DRM_MODE_PAGE_FLIP_EVENT |\
> >                 DRM_MODE_PAGE_FLIP_ASYNC |\
> >                 DRM_MODE_ATOMIC_TEST_ONLY |\
> >                 DRM_MODE_ATOMIC_NONBLOCK |\
> > -               DRM_MODE_ATOMIC_ALLOW_MODESET)
> > +               DRM_MODE_ATOMIC_ALLOW_MODESET |\
> > +               DRM_MODE_ATOMIC_OUT_FENCE)
> 
> just to be pedantic / bisectable, perhaps this should be squashed in
> to patch that actually starts using this flag?  Otherwise there is an
> intermediate state in git where the flag is accepted but ignored..

Sure, I totally agree.

	Gustavo