linux-kernel - Re: [PATCH 0/3] hisi_sas: device id/IPTT collision workaround

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1ega6pp50.fsf@sermon.lab.mkp.net>
Date:	Fri, 15 Apr 2016 16:56:27 -0400
From:	"Martin K. Petersen" <martin.petersen@...cle.com>
To:	John Garry <john.garry@...wei.com>
Cc:	<jejb@...ux.vnet.ibm.com>, <martin.petersen@...cle.com>,
	<linuxarm@...wei.com>, <john.garry2@...l.dcu.ie>,
	<linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<zhangfei.gao@...aro.org>
Subject: Re: [PATCH 0/3] hisi_sas: device id/IPTT collision workaround

>>>>> "John" == John Garry <john.garry@...wei.com> writes:

John> This patchset introduces a workaround to a hw quirk in the
John> HiSilicon SAS controller v2 hw.

John> The quirk is as follows: When a SATA and SAS frame arrives at the
John> host at the same time the frames may be swapped under this
John> condition: SATA device id bit [10:0] == SAS frame IPTT bit [10:0]
John> The workaround is to ensure these 2 values never match. The
John> workaround algorithm is as follows: - SATA device id bit0 always 0
John> - SATA IPTT has no restriction - SAS IPTT bit0 always 1 - SAS
John> device id has no restriction

John> The major restriction of this workaround is the SAS IPTT range is
John> halved, but this should be ok as testing has shown that even using
John> half the IPTT range does not affect performance.

Applied to 4.7/scsi-queue.

Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering