linux-kernel - Re: [PATCH] checkpatch: Whine about ACCESS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1604170743060.2068@localhost6.localdomain6>
Date:	Sun, 17 Apr 2016 07:43:26 +0200 (CEST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Joe Perches <joe@...ches.com>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Andy Whitcroft <apw@...dowen.org>,
	linux-kernel@...r.kernel.org, Davidlohr Bueso <dbueso@...e.de>,
	Davidlohr Bueso <dave@...olabs.net>
Subject: Re: [PATCH] checkpatch: Whine about ACCESS_ONCE



On Sat, 16 Apr 2016, Joe Perches wrote:

> On Sat, 2016-04-16 at 12:04 -0700, Joe Perches wrote:
> > Add a test for use of ACCESS_ONCE that could be written using
> > READ_ONCE or WRITE_ONCE.
> > 
> > --fix it too if desired.
> 
> And here's a simple coccinelle script that does a
> rather better job:
> 
> $ cat access_once.cocci
> @@
> expression e1;
> expression e2;
> @@
> 
> -	ACCESS_ONCE(e1) = e2
> +	WRITE_ONCE(e1, e2)
> 
> @@
> expression e1;
> @@
> 
> -	ACCESS_ONCE(e1)
> +	READ_ONCE(e1)

Looks good to me.  Is this something to put in the kernel?

julia