linux-kernel - Re: [RESEND PATCH v2 3/5] security: Introduce security

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALAqxLXi=+1fOmabeO9o4q_mOcGuDFdxEvEvz3dWEW+g0fkVHw@mail.gmail.com>
Date:	Mon, 18 Apr 2016 09:54:35 -0700
From:	John Stultz <john.stultz@...aro.org>
To:	Baolin Wang <baolin.wang@...aro.org>
Cc:	Serge Hallyn <serge.hallyn@...onical.com>,
	james.l.morris@...cle.com, serge@...lyn.com,
	Thomas Gleixner <tglx@...utronix.de>, pmoore@...hat.com,
	sds@...ho.nsa.gov, Kees Cook <keescook@...omium.org>,
	john.johansen@...onical.com, casey@...aufler-ca.com,
	agruenba@...hat.com, Alexander Viro <viro@...iv.linux.org.uk>,
	Neil Brown <neilb@...e.de>, jann@...jh.net,
	Mark Brown <broonie@...nel.org>,
	Christopher Hall <christopher.s.hall@...el.com>,
	Xunlei Pang <pang.xunlei@...aro.org>,
	Harald Geyer <harald@...ib.org>, Arnd Bergmann <arnd@...db.de>,
	lkml <linux-kernel@...r.kernel.org>,
	LSM List <linux-security-module@...r.kernel.org>
Subject: Re: [RESEND PATCH v2 3/5] security: Introduce security_settime64()

On Thu, Apr 7, 2016 at 11:02 PM, Baolin Wang <baolin.wang@...aro.org> wrote:
> security_settime() uses a timespec, which is not year 2038 safe
> on 32bit systems. Thus this patch introduces the security_settime64()
> function with timespec64 type. We also convert the cap_settime() helper
> function to use the 64bit types.
>
> Move the security_settime() to the head file as a inline function for
> removing that inline helper when following up patches are fixed the
> call sites.
>
> None of the existing hooks is using the timespec argument and therefor
> the patch is not doing any functional changes.
>
> Signed-off-by: Baolin Wang <baolin.wang@...aro.org>

Hey Baolin,
  If you get an ack, like you did from James, please include it in the
commit message of following submissions

Serge, Kees: Any objection to this patch going in via the
tip/timers/core tree with the dependent settimeofday64 call?

Otherwise I'll queue this up for testing.

thanks
-john


.