linux-kernel - Re: [PATCH v6 01/12] usb: hcd: Initialize hcd->flags to 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160418022956.GB32090@shlinux2.ap.freescale.net>
Date:	Mon, 18 Apr 2016 10:29:56 +0800
From:	Peter Chen <hzpeterchen@...il.com>
To:	Roger Quadros <rogerq@...com>, stern@...land.harvard.edu
Cc:	Felipe Balbi <balbi@...nel.org>, gregkh@...uxfoundation.org,
	peter.chen@...escale.com, dan.j.williams@...el.com,
	jun.li@...escale.com, mathias.nyman@...ux.intel.com,
	tony@...mide.com, Joao.Pinto@...opsys.com, abrestic@...omium.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-omap@...r.kernel.org
Subject: Re: [PATCH v6 01/12] usb: hcd: Initialize hcd->flags to 0

On Wed, Apr 06, 2016 at 09:32:22AM +0300, Roger Quadros wrote:
> On 06/04/16 09:09, Felipe Balbi wrote:
> > 
> > Hi,
> > 
> > Roger Quadros <rogerq@...com> writes:
> >> diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
> >> index 2ca2cef..6b1930d 100644
> >> --- a/drivers/usb/core/hcd.c
> >> +++ b/drivers/usb/core/hcd.c
> >> @@ -2706,6 +2706,7 @@ int usb_add_hcd(struct usb_hcd *hcd,
> >>  	int retval;
> >>  	struct usb_device *rhdev;
> >>  
> >> +	hcd->flags = 0;
> > 
> > seems like this would make more sense in usb_del_hcd() instead.
> > 
> 
> OK, I'll move it there.
> 

It depends on Alan's comments, whether only usb_add_hcd/usb_del_hcd
pair can be called repeat. If Alan acks it, I have no idea for it.

-- 

Best Regards,
Peter Chen