linux-kernel - Re: [PATCH] leds: ledtrig-ide-disk: Move ide_blink_delay to ledtrig_ide

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160418165715.4668ffa0@bbrezillon>
Date:	Mon, 18 Apr 2016 16:57:15 +0200
From:	Boris Brezillon <boris.brezillon@...e-electrons.com>
To:	Jacek Anaszewski <j.anaszewski@...sung.com>
Cc:	linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
	rpurdie@...ys.net, ezequiel@...guardiasur.com.ar, pavel@....cz
Subject: Re: [PATCH] leds: ledtrig-ide-disk: Move ide_blink_delay to
 ledtrig_ide_activity()

On Mon, 18 Apr 2016 16:40:46 +0200
Jacek Anaszewski <j.anaszewski@...sung.com> wrote:

> Parameters delay_on and delay_off of led_trigger_blink_oneshot()
> are pointers, to enable blink interval adjustment by LED class drivers
> of the controllers that implement hardware blinking.
> 
> Move ide_blink_delay variable to ledtrig_ide_activity() in order to
> prevent the situation when adjustment committed by one LED class
> driver influences blink interval of the software fallback blink feature,
> that is applied to the drivers that don't implement blink_set op.
> 
> Signed-off-by: Jacek Anaszewski <j.anaszewski@...sung.com>

Reviewed-by: Boris Brezillon <boris.brezillon@...e-electrons.com>

> ---
>  drivers/leds/trigger/ledtrig-ide-disk.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/leds/trigger/ledtrig-ide-disk.c b/drivers/leds/trigger/ledtrig-ide-disk.c
> index c02a3ac..15123d3 100644
> --- a/drivers/leds/trigger/ledtrig-ide-disk.c
> +++ b/drivers/leds/trigger/ledtrig-ide-disk.c
> @@ -18,10 +18,11 @@
>  #define BLINK_DELAY 30
>  
>  DEFINE_LED_TRIGGER(ledtrig_ide);
> -static unsigned long ide_blink_delay = BLINK_DELAY;
>  
>  void ledtrig_ide_activity(void)
>  {
> +	unsigned long ide_blink_delay = BLINK_DELAY;
> +
>  	led_trigger_blink_oneshot(ledtrig_ide,
>  				  &ide_blink_delay, &ide_blink_delay, 0);
>  }



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com