linux-kernel - Re: [PATCH] leds: ledtrig-ide-disk: Move ide_blink_delay to ledtrig_ide

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <5715D998.7030402@samsung.com>
Date:	Tue, 19 Apr 2016 09:09:12 +0200
From:	Jacek Anaszewski <j.anaszewski@...sung.com>
To:	Boris Brezillon <boris.brezillon@...e-electrons.com>
Cc:	linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
	rpurdie@...ys.net, ezequiel@...guardiasur.com.ar, pavel@....cz
Subject: Re: [PATCH] leds: ledtrig-ide-disk: Move ide_blink_delay to
 ledtrig_ide_activity()

Hi Boris,

Thanks for the review, patch applied.

Best regards,
Jacek Anaszewski

On 04/18/2016 04:57 PM, Boris Brezillon wrote:
> On Mon, 18 Apr 2016 16:40:46 +0200
> Jacek Anaszewski <j.anaszewski@...sung.com> wrote:
>
>> Parameters delay_on and delay_off of led_trigger_blink_oneshot()
>> are pointers, to enable blink interval adjustment by LED class drivers
>> of the controllers that implement hardware blinking.
>>
>> Move ide_blink_delay variable to ledtrig_ide_activity() in order to
>> prevent the situation when adjustment committed by one LED class
>> driver influences blink interval of the software fallback blink feature,
>> that is applied to the drivers that don't implement blink_set op.
>>
>> Signed-off-by: Jacek Anaszewski <j.anaszewski@...sung.com>
>
> Reviewed-by: Boris Brezillon <boris.brezillon@...e-electrons.com>