lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 19 Apr 2016 09:58:52 +0200
From:	Heiko Stübner <heiko@...ech.de>
To:	Mark Yao <mark.yao@...k-chips.com>
Cc:	David Airlie <airlied@...ux.ie>, dri-devel@...ts.freedesktop.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>
Subject: Re: [PATCH 2/2] dt-bindings: add document for rk3399-vop

patch subject above:
dt-bindings: add documentation for Rockchip rk3399 display controllers

not everybody skimming over patches directly knows what a vop is ;-)

I still believe even such a trivial patch should also get some form of 
description, something like:

---------
Document compatible values for rk3399 display controllers.
Big and little display controllers are not identical and have differing 
feature sets on the rk3399.
---------

> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: Pawel Moll <pawel.moll@....com>
> Cc: Mark Rutland <mark.rutland@....com>
> Cc: Ian Campbell <ijc+devicetree@...lion.org.uk>
> Cc: Kumar Gala <galak@...eaurora.org>
> 
> Signed-off-by: Mark Yao <mark.yao@...k-chips.com>
> ---
>  .../bindings/display/rockchip/rockchip-vop.txt     |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git
> a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt index
> 5489b59..fd25ea9 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> @@ -8,6 +8,8 @@ Required properties:
>  - compatible: value should be one of the following
>  		"rockchip,rk3288-vop";
>  		"rockchip,rk3036-vop";
> +		"rockchip,rk3399-vop-big";
> +		"rockchip,rk3399-vop-lit";
> 
>  - interrupts: should contain a list of all VOP IP block interrupts in the
>  		 order: VSYNC, LCD_SYSTEM. The interrupt specifier

Powered by blists - more mailing lists