linux-kernel - Re: [PATCH V2 2/3] gpio: tegra: Remove the need of keeping device handle for gpio driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160419123323.GC8284@ulmo.ba.sec>
Date:	Tue, 19 Apr 2016 14:33:23 +0200
From:	Thierry Reding <thierry.reding@...il.com>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	linus.walleij@...aro.org, gnurou@...il.com, swarren@...dotorg.org,
	linux-gpio@...r.kernel.org, linux-tegra@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 2/3] gpio: tegra: Remove the need of keeping device
 handle for gpio driver

On Tue, Apr 19, 2016 at 03:13:39PM +0530, Laxman Dewangan wrote:
> Remove the file static device handle variable for keeping device handle
> of driver as this is just required for error prints. The required device
> handle are available from gpiochip structure.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>
> ---
>  drivers/gpio/gpio-tegra.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
> index 1b0c497..de022a9 100644
> --- a/drivers/gpio/gpio-tegra.c
> +++ b/drivers/gpio/gpio-tegra.c
> @@ -80,7 +80,6 @@ struct tegra_gpio_soc_config {
>  	u32 upper_offset;
>  };
>  
> -static struct device *dev;
>  static struct irq_domain *irq_domain;
>  static void __iomem *regs;
>  static u32 tegra_gpio_bank_count;
> @@ -240,7 +239,8 @@ static int tegra_gpio_irq_set_type(struct irq_data *d, unsigned int type)
>  
>  	ret = gpiochip_lock_as_irq(&tegra_gpio_chip, gpio);
>  	if (ret) {
> -		dev_err(dev, "unable to lock Tegra GPIO %d as IRQ\n", gpio);
> +		dev_err(tegra_gpio_chip.parent,
> +			"unable to lock Tegra GPIO %d as IRQ\n", gpio);

Can't we get rid of the tegra_gpio_chip global variable altogether? We
set a struct tegra_gpio_bank * as the chip data for each of the
interrupts, so if we added a back link to the GPIO chip to each bank
we could easily get at the GPIO chip (and its parent device) from the
IRQ chip implementation.

>  		return ret;
>  	}
>  
> @@ -465,8 +465,6 @@ static int tegra_gpio_probe(struct platform_device *pdev)
>  	int i;
>  	int j;
>  
> -	dev = &pdev->dev;
> -
>  	config = of_device_get_match_data(&pdev->dev);
>  	if (!config) {
>  		dev_err(&pdev->dev, "Error: No device match found\n");
> @@ -488,6 +486,8 @@ static int tegra_gpio_probe(struct platform_device *pdev)
>  	}
>  
>  	tegra_gpio_chip.ngpio = tegra_gpio_bank_count * 32;
> +	tegra_gpio_chip.parent = &pdev->dev;
> +

This adds a gratuitous blank line.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)