linux-kernel - Re: [PATCH] mcb: Fixed bar number assignment for the gdd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 20 Apr 2016 10:57:55 +0200
From:	Johannes Thumshirn <jthmshirn@...e.de>
To:	Andreas Werner <andreas.werner@....de>
Cc:	morbidrsa@...il.com, linux-kernel@...r.kernel.org,
	jthumshirn@...e.de
Subject: Re: [PATCH] mcb: Fixed bar number assignment for the gdd

On Wed, Apr 20, 2016 at 08:35:47AM +0200, Andreas Werner wrote:
> The bar number is found in reg2 within the gdd. Therefore
> we need to change the assigment from reg1 to reg2 which
> is the correct location.
> 
> Signed-off-by: Andreas Werner <andreas.werner@....de>
> ---
>  drivers/mcb/mcb-parse.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mcb/mcb-parse.c b/drivers/mcb/mcb-parse.c
> index 0049269..b0155b0 100644
> --- a/drivers/mcb/mcb-parse.c
> +++ b/drivers/mcb/mcb-parse.c
> @@ -57,7 +57,7 @@ static int chameleon_parse_gdd(struct mcb_bus *bus,
>  	mdev->id = GDD_DEV(reg1);
>  	mdev->rev = GDD_REV(reg1);
>  	mdev->var = GDD_VAR(reg1);
> -	mdev->bar = GDD_BAR(reg1);
> +	mdev->bar = GDD_BAR(reg2);
>  	mdev->group = GDD_GRP(reg2);
>  	mdev->inst = GDD_INS(reg2);
>  
> -- 
> 2.6.2
> 

Applied, thanks.

-- 
Johannes Thumshirn                                          Storage
jthumshirn@...e.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850