linux-kernel - Re: [RFC PATCH v2 05/10] i2c: add support for ACPI reconfigure notifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 22 Apr 2016 00:27:14 +0300
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Octavian Purdila <octavian.purdila@...el.com>
Cc:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Len Brown <lenb@...nel.org>,
	Matt Fleming <matt@...eblueprint.co.uk>,
	Mark Brown <broonie@...nel.org>,
	Wolfram Sang <wsa@...-dreams.de>,
	Joel Becker <jlbec@...lplan.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	linux-efi@...r.kernel.org, linux-i2c@...r.kernel.org,
	linux-spi <linux-spi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	irina.tirdea@...el.com
Subject: Re: [RFC PATCH v2 05/10] i2c: add support for ACPI reconfigure notifications

On Wed, Apr 20, 2016 at 1:39 AM, Octavian Purdila
<octavian.purdila@...el.com> wrote:
> This patch adds supports for I2C device enumeration and removal via
> ACPI reconfiguration notifications that are send as a result of an
> ACPI table load or unload operation.

>
>         acpi_dev_free_resource_list(&resource_list);
>
> +       strlcpy(info->type, dev_name(&adev->dev), sizeof(info->type));

strscpy() ?

> +static int acpi_i2c_match_adapter(struct device *dev, void *data)
> +{
> +       struct i2c_adapter *adapter = i2c_verify_adapter(dev);
> +
> +       if (!adapter)
> +               return 0;
> +

> +       return ACPI_HANDLE(dev) == (acpi_handle)data;

What is suppose to return? Hidden bool to integer conversion is not
best option I suppose.

> +}
> +
> +static int acpi_i2c_match_device(struct device *dev, void *data)
> +{
> +       return ACPI_COMPANION(dev) == data;

Ditto.

> +}

-- 
With Best Regards,
Andy Shevchenko