linux-kernel - Re: [PATCH] HID: uhid: Fixes a bug with userspace bluetooth stacks, which causes hangs during certain operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANndSK=tc_aywb6_uQ9FK4Br1gtGUhm_EYCSM0MZsrnEi_x=hg@mail.gmail.com>
Date:	Thu, 21 Apr 2016 14:27:47 -0700
From:	Roderick Colenbrander <roderick@...kai.com>
To:	kbuild test robot <lkp@...el.com>
Cc:	kbuild-all@...org, linux-input@...r.kernel.org,
	David Herrmann <dh.herrmann@...il.com>,
	Tim Bird <tim.bird@...ymobile.com>,
	linux-kernel@...r.kernel.org,
	Roderick Colenbrander <roderick.colenbrander@...y.com>,
	stable@...r.kernel.org
Subject: Re: [PATCH] HID: uhid: Fixes a bug with userspace bluetooth stacks,
 which causes hangs during certain operations

Please ignore this revision of the patch, there was a small merge
conflict on my end.

On Thu, Apr 21, 2016 at 2:15 PM, kbuild test robot <lkp@...el.com> wrote:
> Hi,
>
> [auto build test WARNING on hid/for-next]
> [also build test WARNING on v4.6-rc4 next-20160421]
> [if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
>
> url:    https://github.com/0day-ci/linux/commits/roderick-gaikai-com/HID-uhid-Fixes-a-bug-with-userspace-bluetooth-stacks-which-causes-hangs-during-certain-operations/20160422-050505
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-next
> config: x86_64-randconfig-x003-201616 (attached as .config)
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=x86_64
>
> All warnings (new ones prefixed by >>):
>
>    In file included from arch/x86/include/asm/atomic.h:4:0,
>                     from include/linux/atomic.h:4,
>                     from drivers/hid/uhid.c:13:
>    drivers/hid/uhid.c: In function 'uhid_event_from_user':
>    drivers/hid/uhid.c:403:6: error: implicit declaration of function 'is_compat_task' [-Werror=implicit-function-declaration]
>      if (is_compat_task()) {
>          ^
>    include/linux/compiler.h:151:30: note: in definition of macro '__trace_if'
>      if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
>                                  ^
>>> drivers/hid/uhid.c:403:2: note: in expansion of macro 'if'
>      if (is_compat_task()) {
>      ^
>    cc1: some warnings being treated as errors
>
> vim +/if +403 drivers/hid/uhid.c
>
>    387          __u8 phys[64];
>    388          __u8 uniq[64];
>    389
>    390          compat_uptr_t rd_data;
>    391          __u16 rd_size;
>    392
>    393          __u16 bus;
>    394          __u32 vendor;
>    395          __u32 product;
>    396          __u32 version;
>    397          __u32 country;
>    398  } __attribute__((__packed__));
>    399
>    400  static int uhid_event_from_user(const char __user *buffer, size_t len,
>    401                                  struct uhid_event *event)
>    402  {
>  > 403          if (is_compat_task()) {
>    404                  u32 type;
>    405
>    406                  if (get_user(type, buffer))
>    407                          return -EFAULT;
>    408
>    409                  if (type == UHID_CREATE) {
>    410                          /*
>    411                           * This is our messed up request with compat pointer.
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation



-- 
Roderick Colenbrander
Manager of Software Engineering
Gaikai, a Sony Computer Entertainment Company
roderick@...kai.com