linux-kernel - Re: [alsa-devel] linux-4.6-rc4/sound/pci/ens1370.c:1551: possible bad expression ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 21 Apr 2016 08:38:48 +0200
From:	Clemens Ladisch <clemens@...isch.de>
To:	David Binderman <dcb314@...mail.com>,
	"perex@...ex.cz" <perex@...ex.cz>,
	"tiwai@...e.com" <tiwai@...e.com>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [alsa-devel] linux-4.6-rc4/sound/pci/ens1370.c:1551: possible bad
	expression ?

David Binderman wrote:
> [linux-4.6-rc4/sound/pci/ens1370.c:1551]: (style) Expression '(X & 0xf0000)>= 0x4' is always false.

What tool generated this message?

> Source code is
>
>     if ((ensoniq->ctrl & ES_1371_GPIO_OUTM)>= 4)
>         val = 1;

This message is wrong; it is certainly possible for this to be true.

However, there is a different bug: 4 must be ES_1371_GPIO_OUT(4).


Regards,
Clemens