linux-kernel - Re: [PATCH] Revert "cpufreq: governor: Fix negative idle_time when configured with CONFIG_HZ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160422033307.GQ29799@vireshk-i7>
Date:	Fri, 22 Apr 2016 09:03:07 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	"Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:	Linux PM list <linux-pm@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Chen Yu <yu.c.chen@...el.com>,
	Timo Valtoaho <timo.valtoaho@...il.com>
Subject: Re: [PATCH] Revert "cpufreq: governor: Fix negative idle_time when
 configured with CONFIG_HZ_PERIODIC"

On 21-04-16, 20:57, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> Revert commit 0df35026c6a5 (cpufreq: governor: Fix negative idle_time
> when configured with CONFIG_HZ_PERIODIC) that introduced a regression
> by causing the ondemand cpufreq governor to misbehave for
> CONFIG_TICK_CPU_ACCOUNTING unset (the frequency goes up to the max at
> one point and stays there indefinitely).
> 
> The revert takes subsequent modifications of the code in question into
> account.
> 
> Fixes: 0df35026c6a5 (cpufreq: governor: Fix negative idle_time when configured with CONFIG_HZ_PERIODIC)
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=115261
> Reported-and-tested-by: Timo Valtoaho <timo.valtoaho@...il.com>
> Cc: 4.5+ <stable@...r.kernel.org> # 4.5+
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> ---
>  drivers/cpufreq/cpufreq_governor.c |    8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> Index: linux-pm/drivers/cpufreq/cpufreq_governor.c
> ===================================================================
> --- linux-pm.orig/drivers/cpufreq/cpufreq_governor.c
> +++ linux-pm/drivers/cpufreq/cpufreq_governor.c
> @@ -146,12 +146,8 @@ unsigned int dbs_update(struct cpufreq_p
>  		wall_time = cur_wall_time - j_cdbs->prev_cpu_wall;
>  		j_cdbs->prev_cpu_wall = cur_wall_time;
>  
> -		if (cur_idle_time <= j_cdbs->prev_cpu_idle) {
> -			idle_time = 0;
> -		} else {
> -			idle_time = cur_idle_time - j_cdbs->prev_cpu_idle;
> -			j_cdbs->prev_cpu_idle = cur_idle_time;
> -		}
> +		idle_time = cur_idle_time - j_cdbs->prev_cpu_idle;
> +		j_cdbs->prev_cpu_idle = cur_idle_time;
>  
>  		if (ignore_nice) {
>  			u64 cur_nice = kcpustat_cpu(j).cpustat[CPUTIME_NICE];

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

-- 
viresh