linux-kernel - Re: [PATCH V3 29/29] ethernet: use parity8 in broadcom/tg3.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAMet4B7K0N3cq24riNO1uC6QaOCx2FFRV77YoQ9QFV1wFq-jfA@mail.gmail.com>
Date:	Fri, 22 Apr 2016 10:16:24 +0530
From:	Siva Reddy Kallam <siva.kallam@...adcom.com>
To:	zengzhaoxiu@....com, Prashant Sreedharan <prashant@...adcom.com>,
	Michael Chan <mchan@...adcom.com>,
	Zhaoxiu Zeng <zhaoxiu.zeng@...il.com>
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH V3 29/29] ethernet: use parity8 in broadcom/tg3.c

On Thu, Apr 14, 2016 at 8:42 AM, <zengzhaoxiu@....com> wrote:
>
> From: Zhaoxiu Zeng <zhaoxiu.zeng@...il.com>
>
> Signed-off-by: Zhaoxiu Zeng <zhaoxiu.zeng@...il.com>
Looks good to me.
Acked-by: Siva Reddy Kallam <siva.kallam@...adcom.com>
> ---
>  drivers/net/ethernet/broadcom/tg3.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
> index 3010080..802a429 100644
> --- a/drivers/net/ethernet/broadcom/tg3.c
> +++ b/drivers/net/ethernet/broadcom/tg3.c
> @@ -12939,11 +12939,7 @@ static int tg3_test_nvram(struct tg3 *tp)
>
>                 err = -EIO;
>                 for (i = 0; i < NVRAM_SELFBOOT_DATA_SIZE; i++) {
> -                       u8 hw8 = hweight8(data[i]);
> -
> -                       if ((hw8 & 0x1) && parity[i])
> -                               goto out;
> -                       else if (!(hw8 & 0x1) && !parity[i])
> +                       if (parity8(data[i]) == !!parity[i])
>                                 goto out;
>                 }
>                 err = 0;
> --
> 2.5.0
>
>