linux-kernel - Re: [PATCH v3] dmaengine: tegra-apb: proper default init of channel slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160422143700.GA7068@ulmo.ba.sec>
Date:	Fri, 22 Apr 2016 16:37:00 +0200
From:	Thierry Reding <thierry.reding@...il.com>
To:	Shardar Shariff Md <smohammed@...dia.com>
Cc:	ldewangan@...dia.com, vinod.koul@...el.com,
	dan.j.williams@...el.com, swarren@...dotorg.org, gnurou@...il.com,
	dmaengine@...r.kernel.org, linux-tegra@...r.kernel.org,
	linux-kernel@...r.kernel.org, jonathanh@...dia.com
Subject: Re: [PATCH v3] dmaengine: tegra-apb: proper default init of channel
 slave_id

On Fri, Apr 22, 2016 at 07:44:39PM +0530, Shardar Shariff Md wrote:
> Initialize default channel slave_id(req_sel) to invalid id
> (i.e max supported slave id + 1) to avoid overwriting of slave_id
> during tegra_dma_slave_config() with client data if slave_id
> is not initialized through DT
> 
> Signed-off-by: Shardar Shariff Md <smohammed@...dia.com>
> 
> ---
> Changes from v1:
> - Instead of initializing the slave id to -1 define macros for
>   max slave id and invalid slave id and do the checks accordingly.
> 
> Changes from v2:
> - Check slave id boundary before dma channel is allocated to
>   avoid channel leakage.
> ---
>  drivers/dma/tegra20-apb-dma.c | 18 +++++++++++++++---
>  1 file changed, 15 insertions(+), 3 deletions(-)

Looks good to me, though I'm not a DMA engine export, so I'll only
offer:

Acked-by: Thierry Reding <treding@...dia.com>

Perhaps Jon would be comfortable enough to give a Reviewed-by?

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)