linux-kernel - RE: [PATCH] rapidio: fix potential NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 22 Apr 2016 14:39:13 +0000
From:	"Bounine, Alexandre" <Alexandre.Bounine@....com>
To:	Vladimir Zapolskiy <vz@...ia.com>,
	Matt Porter <mporter@...nel.crashing.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Andrew Morton" <akpm@...ux-foundation.org>
Subject: RE: [PATCH] rapidio: fix potential NULL pointer dereference

Thank you.

Ack-ed.

> -----Original Message-----
> From: Vladimir Zapolskiy [mailto:vz@...ia.com]
> Sent: Thursday, April 21, 2016 4:05 PM
> To: Matt Porter; Bounine, Alexandre
> Cc: linux-kernel@...r.kernel.org
> Subject: [PATCH] rapidio: fix potential NULL pointer dereference
> 
> The change fixes improper check for a returned error value by
> class_create() function, which on error returns ERR_PTR() value,
> thus the original check always results in a dead code on error path.
> 
> Signed-off-by: Vladimir Zapolskiy <vz@...ia.com>
> ---
>  drivers/rapidio/devices/rio_mport_cdev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/rapidio/devices/rio_mport_cdev.c
> b/drivers/rapidio/devices/rio_mport_cdev.c
> index 5d4d918..96168b8 100644
> --- a/drivers/rapidio/devices/rio_mport_cdev.c
> +++ b/drivers/rapidio/devices/rio_mport_cdev.c
> @@ -2669,9 +2669,9 @@ static int __init mport_init(void)
> 
>  	/* Create device class needed by udev */
>  	dev_class = class_create(THIS_MODULE, DRV_NAME);
> -	if (!dev_class) {
> +	if (IS_ERR(dev_class)) {
>  		rmcd_error("Unable to create " DRV_NAME " class");
> -		return -EINVAL;
> +		return PTR_ERR(dev_class);
>  	}
> 
>  	ret = alloc_chrdev_region(&dev_number, 0, RIO_MAX_MPORTS,
> DRV_NAME);
> --
> 2.1.4